From c0b8d10addd6b58408d006556f00d1fffbc138be Mon Sep 17 00:00:00 2001 From: josh Date: Fri, 21 Aug 2026 17:02:12 +1000 Subject: [PATCH] Make progressive achievements get notifications when complete --- app/Services/Achievements/AchievementService.php | 3 ++- bootstrap/app.php | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/Services/Achievements/AchievementService.php b/app/Services/Achievements/AchievementService.php index f5b869f..9ab7d72 100644 --- a/app/Services/Achievements/AchievementService.php +++ b/app/Services/Achievements/AchievementService.php @@ -98,7 +98,8 @@ class AchievementService ->where('achievement_id', $achievement->id) ->first(); - $alreadyUnlocked = $existing !== null; + $alreadyUnlocked = $existing !== null + && (! $achievement->progressive || $existing->progress >= $achievement->threshold); UserAchievement::updateOrCreate( ['user_id' => $user->id, 'achievement_id' => $achievement->id], diff --git a/bootstrap/app.php b/bootstrap/app.php index f9260c0..5ead8d9 100644 --- a/bootstrap/app.php +++ b/bootstrap/app.php @@ -67,7 +67,7 @@ return Application::configure(basePath: dirname(__DIR__)) 'message' => 'You don\'t have permission to access this page.', ], 404 => [ - 'title' => 'You Flight Has Been Cancelled', + 'title' => 'Your Flight Has Been Cancelled', 'message' => 'The page you are looking for doesn\'t exist or has been moved.', ], 419 => [